bootstrap major change detection implementation #115898

onur-ozkan · 2023-09-16T16:29:54Z

The use of changelog-seen and bootstrap/CHANGELOG.md has not been functional in any way for many years. We often do major/breaking changes but never update the changelog file or the changelog-seen. This is an alternative method for tracking major or breaking changes and informing developers when such changes occur.

Example output when bootstrap detects a major change:

rustbot · 2023-09-16T16:30:03Z

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

rustbot · 2023-09-16T17:00:55Z

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

src/bootstrap/lib.rs

Mark-Simulacrum · 2023-09-30T23:05:59Z

r=me with it kept or removed

Signed-off-by: onur-ozkan <[email protected]>

Mark-Simulacrum · 2023-10-01T21:51:10Z

@bors r+

bors · 2023-10-01T21:51:12Z

📌 Commit 7d3dcd9 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

bors · 2023-10-02T07:41:55Z

⌛ Testing commit 7d3dcd9 with merge 781ebbe...

bors · 2023-10-02T09:40:35Z

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 781ebbe to master...

rust-timer · 2023-10-02T11:49:32Z

Finished benchmarking commit (781ebbe): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.9%	[2.9%, 2.9%]	1
Improvements ✅ (primary)	-3.6%	[-3.6%, -3.6%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-3.6%	[-3.6%, -3.6%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 627.987s -> 626.682s (-0.21%)
Artifact size: 273.32 MiB -> 273.33 MiB (0.01%)

RalfJung · 2023-10-06T16:08:53Z

Doing this without a transition is a bit painful. I often switch between branches that are based on slightly different commits, and now that I updated to change-id, when I check out an old branch I cannot build it any more:

failed to parse TOML configuration 'config.toml': unknown field `change-id`, expected one of `changelog-seen`, `build`, `install`, `llvm`, `rust`, `target`, `dist`, `profile`

Mark-Simulacrum · 2023-10-06T16:18:13Z

You can just omit both and ignore the warnings. It might not be an amazing option.

…=Mark-Simulacrum bootstrap major change detection implementation The use of `changelog-seen` and `bootstrap/CHANGELOG.md` has not been functional in any way for many years. We often do major/breaking changes but never update the changelog file or the `changelog-seen`. This is an alternative method for tracking major or breaking changes and informing developers when such changes occur. Example output when bootstrap detects a major change: ![image](https://github.com/rust-lang/rust/assets/39852038/ee802dfa-a02b-488b-a433-f853ce079b8a)

…=Mark-Simulacrum bootstrap major change detection implementation The use of `changelog-seen` and `bootstrap/CHANGELOG.md` has not been functional in any way for many years. We often do major/breaking changes but never update the changelog file or the `changelog-seen`. This is an alternative method for tracking major or breaking changes and informing developers when such changes occur. Example output when bootstrap detects a major change: ![image](https://github.com/rust-lang/rust/assets/39852038/ee802dfa-a02b-488b-a433-f853ce079b8a)

`changelog-seen` was deprecated in rust-lang/rust#115898 ``` WARNING: The use of `changelog-seen` is deprecated. Please refer to `change-id` option in `config.example.toml` instead. WARNING: The `change-id` is missing in the `config.toml`. This means that you will not be able to track the major changes made to the bootstrap configurations. note: to silence this warning, add `change-id = 115898` at the top of `config.toml` ```

pietroalbini · 2023-10-11T09:03:50Z

Yeah, this is fairly annoying when switching to other commits / versions :(

pcc · 2023-10-20T22:48:57Z

While I was preparing #116998 I noticed that the change-id is mentioned in several places that will need to be updated and not just the ones mentioned in the automatic comment (otherwise either some documentation will become stale or bootstrap tests will start failing). I expect that developers will notice the test failures, but they won't notice the stale documentation.

onur-ozkan · 2023-10-21T07:06:06Z

change-id shouldn't have any impact as it's solely used for logging versions in case more recent ones exist. It doesn't directly affect the configuration.

otherwise either some documentation will become stale or bootstrap tests will start failing

This shouldn't be possible.

pcc · 2023-10-23T19:11:53Z

Without the bootstrap test changes, the following test fails:

======================================================================
FAIL: test_no_args (bootstrap_test.GenerateAndParseConfig.test_no_args)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/mnt/disk2/pcc/rust/src/bootstrap/bootstrap_test.py", line 106, in test_no_args
    self.assertEqual(build.get_toml("change-id"), '115898')
AssertionError: '116998' != '115898'
- 116998
+ 115898

Regarding the stale documentation, maybe we should just remove the change-id from as many of these places as possible? Either way there will still be a warning and the user will have the option of adding a change-id if they want change tracking.

onur-ozkan · 2023-10-23T19:45:17Z

In https://rustc-dev-guide.rust-lang.org, sure, it would be better to remove change-id from sample configurations.

AssertionError: '116998' != '115898'

Removing this assertion shouldn't be problem I think.

…ion, r=albertlarsan68 remove change-id assertion in bootstrap test In the bootstrap test, the assertion of the change-id fails whenever we update the change-id next to a breaking change in build configurations. This commit removes the assertion, as it's not critical or useful to have. ref rust-lang#115898 (comment)

Rollup merge of rust-lang#117105 - onur-ozkan:remove-change-id-assertion, r=albertlarsan68 remove change-id assertion in bootstrap test In the bootstrap test, the assertion of the change-id fails whenever we update the change-id next to a breaking change in build configurations. This commit removes the assertion, as it's not critical or useful to have. ref rust-lang#115898 (comment)

rustbot assigned Mark-Simulacrum Sep 16, 2023

onur-ozkan marked this pull request as draft September 16, 2023 16:31

onur-ozkan force-pushed the config-change-tracking branch from 1bafb41 to 83604cc Compare September 16, 2023 16:31

This comment has been minimized.

Sign in to view

onur-ozkan force-pushed the config-change-tracking branch 2 times, most recently from 2b59a28 to 7e62ddd Compare September 16, 2023 16:44

rustbot added the A-meta Area: Issues & PRs about the rust-lang/rust repository itself label Sep 16, 2023

onur-ozkan force-pushed the config-change-tracking branch from 9375b35 to 792ee61 Compare September 16, 2023 16:49

This comment has been minimized.

Sign in to view

onur-ozkan force-pushed the config-change-tracking branch from 792ee61 to 6ffbce3 Compare September 16, 2023 17:00

onur-ozkan marked this pull request as ready for review September 16, 2023 17:00

onur-ozkan force-pushed the config-change-tracking branch from 6ffbce3 to de75168 Compare September 16, 2023 17:29

This comment has been minimized.

Sign in to view

onur-ozkan force-pushed the config-change-tracking branch from de75168 to 3e878ef Compare September 17, 2023 04:47

onur-ozkan mentioned this pull request Sep 17, 2023

optimize and cleanup bootstrap source #115514

Merged

Mark-Simulacrum reviewed Sep 30, 2023

View reviewed changes

src/bootstrap/lib.rs Outdated Show resolved Hide resolved

onur-ozkan added 3 commits October 1, 2023 16:54

implement major change tracking for the bootstrap configuration

957de61

Signed-off-by: onur-ozkan <[email protected]>

add Changelog topic to bootstrap/README.md

78eed2d

Signed-off-by: onur-ozkan <[email protected]>

add triagebot notification for bootstrap config changes

7d3dcd9

Signed-off-by: onur-ozkan <[email protected]>

onur-ozkan force-pushed the config-change-tracking branch from 3e878ef to 7d3dcd9 Compare October 1, 2023 13:55

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 1, 2023

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 2, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 2, 2023

bors merged commit 781ebbe into rust-lang:master Oct 2, 2023
11 checks passed

rustbot added this to the 1.75.0 milestone Oct 2, 2023

pvdrz mentioned this pull request Oct 4, 2023

Fix divergence from upstream master ferrocene/ferrocene#23

Merged

eopb mentioned this pull request Oct 10, 2023

[suggested.md] remove deprecated changelog-seen from shell.nix rust-lang/rustc-dev-guide#1805

Closed

eopb mentioned this pull request Oct 10, 2023

[suggested.md] changelog-seen -> change-id in shell.nix rust-lang/rustc-dev-guide#1806

Merged

onur-ozkan mentioned this pull request Oct 21, 2023

Improve android-ndk property interface #116998

Merged

This was referenced Oct 23, 2023

remove change-id assertion in bootstrap test #117105

Merged

remove change-id from sample build configuration rust-lang/rustc-dev-guide#1813

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bootstrap major change detection implementation #115898

bootstrap major change detection implementation #115898

onur-ozkan commented Sep 16, 2023 •

edited

Loading

rustbot commented Sep 16, 2023

This comment has been minimized.

This comment has been minimized.

rustbot commented Sep 16, 2023

This comment has been minimized.

Mark-Simulacrum commented Sep 30, 2023

Mark-Simulacrum commented Oct 1, 2023

bors commented Oct 1, 2023

bors commented Oct 2, 2023

bors commented Oct 2, 2023

rust-timer commented Oct 2, 2023

RalfJung commented Oct 6, 2023

Mark-Simulacrum commented Oct 6, 2023

pietroalbini commented Oct 11, 2023

pcc commented Oct 20, 2023

onur-ozkan commented Oct 21, 2023

pcc commented Oct 23, 2023

onur-ozkan commented Oct 23, 2023

bootstrap major change detection implementation #115898

bootstrap major change detection implementation #115898

Conversation

onur-ozkan commented Sep 16, 2023 • edited Loading

rustbot commented Sep 16, 2023

This comment has been minimized.

This comment has been minimized.

rustbot commented Sep 16, 2023

This comment has been minimized.

Mark-Simulacrum commented Sep 30, 2023

Mark-Simulacrum commented Oct 1, 2023

bors commented Oct 1, 2023

bors commented Oct 2, 2023

bors commented Oct 2, 2023

rust-timer commented Oct 2, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

RalfJung commented Oct 6, 2023

Mark-Simulacrum commented Oct 6, 2023

pietroalbini commented Oct 11, 2023

pcc commented Oct 20, 2023

onur-ozkan commented Oct 21, 2023

pcc commented Oct 23, 2023

onur-ozkan commented Oct 23, 2023

onur-ozkan commented Sep 16, 2023 •

edited

Loading